Approval Not Working - ThoughtWorks Studios

Aug 12, 2008 3:42pm

Anthony Abate 15 post(s) #2095

I have placed an approval tag in the stage config.

It even says “approval needed for this stage”

however, I can not seem to initiate an approval.

Aug 13, 2008 12:33am

Jez Humble Administrator 108 post(s) #2097

Hey Anthony

One thing with the way we implemented approvals in 1.0 is that you have to put the approval in the stage before the “gate”. If this isn’t the problem you’re experiencing, please can you paste the relevant part of your config file here?

Also, what are you doing to try and initiate the approval?

Aug 13, 2008 7:19pm

Anthony Abate 15 post(s) #2102

Ive put approvals in all my stages just to verify If I can get it to work or not.

Once I do that.. i dont seem to be able to “start” anything, perhaps Im not clicking on the right thing(s)

Aug 14, 2008 2:17am

Jez Humble Administrator 108 post(s) #2105

So the first stage should always be triggered by modifications. This is actually kind of a flaw in the way we modelled approvals which we are in the process of fixing. So if your first stage isn’t triggered, you would have to force it with the force build button.

Further stages can only be triggered only once the previous stage has completed (successfully or not). You’ll notice the trigger arrows are outlined when they can’t be clicked on, and filled when they can be.

Again, this model isn’t really ideal and we’re working on changing it – but that’s the way it works right now.

Sep 5, 2008 2:18am

Ni 2 post(s) #2270

I wasn’t able to get the approval thing working either. And it does show the ” stage requires approval”. Here is my stage config:

Sep 5, 2008 4:16pm

Chris Stevenson Administrator 27 post(s) #2275

You should be able to see the approval button on the pipeline activity page

For your situtation you should see something like this (please excuse the ASCII art): [PreviousStage] |> [Release] |> [NextStage]

The <approval /> actually applies to the next stage, so in your case the approval would apply to whatever comes after the Release stage. Is that what you wanted? If it is the Release stage itself that you want to trigger, you should put the <approval /> tag on the previous stage.

We have changed this in our current builds and it will work more intuitively in the next release.

If that is not your problem, please feel free to get back to us here or contact support

Approval Not Working#790

Voices

Aug 12, 2008 3:42pm Anthony Abate 15 post(s) #2095	I have placed an approval tag in the stage config. It even says “approval needed for this stage” however, I can not seem to initiate an approval.

Aug 13, 2008 12:33am Jez Humble Administrator 108 post(s) #2097	Hey Anthony One thing with the way we implemented approvals in 1.0 is that you have to put the approval in the stage before the “gate”. If this isn’t the problem you’re experiencing, please can you paste the relevant part of your config file here? Also, what are you doing to try and initiate the approval?

Aug 13, 2008 7:19pm Anthony Abate 15 post(s) #2102	Ive put approvals in all my stages just to verify If I can get it to work or not. Once I do that.. i dont seem to be able to “start” anything, perhaps Im not clicking on the right thing(s)

Aug 14, 2008 2:17am Jez Humble Administrator 108 post(s) #2105	So the first stage should always be triggered by modifications. This is actually kind of a flaw in the way we modelled approvals which we are in the process of fixing. So if your first stage isn’t triggered, you would have to force it with the force build button. Further stages can only be triggered only once the previous stage has completed (successfully or not). You’ll notice the trigger arrows are outlined when they can’t be clicked on, and filled when they can be. Again, this model isn’t really ideal and we’re working on changing it – but that’s the way it works right now.

Sep 5, 2008 2:18am Ni 2 post(s) #2270	I wasn’t able to get the approval thing working either. And it does show the ” stage requires approval”. Here is my stage config: <stage name="Release"> <jobs> <job name="Packaging"> <tasks> <nant buildfile="rlap.build" target="release" /> </tasks> </job> </jobs> <approval /> </stage>

Sep 5, 2008 4:16pm Chris Stevenson Administrator 27 post(s) #2275	You should be able to see the approval button on the pipeline activity page For your situtation you should see something like this (please excuse the ASCII art): [PreviousStage] \|> [Release] \|> [NextStage] The <approval /> actually applies to the next stage, so in your case the approval would apply to whatever comes after the Release stage. Is that what you wanted? If it is the Release stage itself that you want to trigger, you should put the <approval /> tag on the previous stage. We have changed this in our current builds and it will work more intuitively in the next release. If that is not your problem, please feel free to get back to us here or contact support